Re: [libvirt] [PATCH] qemu: Parse current balloon value returned by query_balloon.

On 06/03/2011 02:24 AM, Osier Yang wrote: > Qemu once supported following memory stats which will returned by > "query_balloon": > > stat_put(dict, "actual", actual); > stat_put(dict, "mem_swapped_in", dev->stats[VIRTIO_BALLOON_S_SWAP_IN]); > stat_put(dict, "mem_swapped_out", dev->stats[VIRTIO_BALLOON_S_SWAP_OUT]); > stat_put(dict, "major_page_faults", dev->stats[VIRTIO_BALLOON_S_MAJFLT]); > stat_put(dict, "minor_page_faults", dev->stats[VIRTIO_BALLOON_S_MINFLT]); > stat_put(dict, "free_mem", dev->stats[VIRTIO_BALLOON_S_MEMFREE]); > stat_put(dict, "total_mem", dev->stats[VIRTIO_BALLOON_S_MEMTOT]); > > include/libvirt/libvirt.h.in | 4 +++- > src/libvirt.c | 2 ++ > src/qemu/qemu_monitor_json.c | 12 ++++++++++++ > tools/virsh.c | 2 ++ > 4 files changed, 19 insertions(+), 1 deletions(-) In addition to Matthias' review, does qemu_monitor_text.c also need to support this? I think we need a v2.