Re: [libvirt] [PATCH] fix a bug of sheepdog storage driver

On 02/08/2013 12:26 AM, Osier Yang wrote: Your 'From:' line didn't match your 'Signed-off-by:' line. That makes our generated AUTHORS file look strange. I would suggest doing: git config --global sendemail.from 'Harry Wei <harryxiyou(a)gmail.com&gt;&#39; so that future patches sent through 'git send-email' have the correct envelope settings, and/or edit your gmail settings to associate a name with your address (I'm not sure which of those two steps will matter, or if both are needed). Meanwhile, I touched up the authorship information on this commit. I tweaked the subject line to: sheepdog: skip refresh on creation failure so that it is more informative. Theoretically, ALL patches should either fix a bug or add a feature, so claiming that a patch "fixes a bug" is redundant. Knowing a bit about WHAT was fixed makes the one-line summary much more useful. Patch now pushed; congratulations on finally getting it right, and hopefully next time isn't quite so difficult. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org