Re: [libvirt] [PATCH 4/4] bhyve: host API support

Daniel P. Berrange wrote: > On Thu, Mar 20, 2014 at 09:39:23AM +0100, Wojciech Macek wrote: > > New functionalities: > > - connectGetMaxVcpus - on bhyve hardcode this value to 16 > > - nodeGetFreeMemory - do not use physmem_get on FreeBSD, since > > it might get wrong value on systems with > > more than 100GB of RAM > > - nodeGetCPUMap - wrapper only for mapping function, currently not > > supported by FreeBSD > > - nodeSet/GetMemoryParameters - wrapper only for future improvements, > > currently not supported by FreeBSD > > --- > > src/bhyve/bhyve_driver.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++ > > src/nodeinfo.c | 19 ++++++++++++++ > > 2 files changed, 85 insertions(+) > ACK if the nitpicks are fixed. I'll give it a test and then push with the nitpick fixes squashed in.