Re: [libvirt-go-xml PATCH 1/2] gitlab: add CI definition for GitLab
On Tue, Apr 07, 2020 at 04:38:39PM +0200, Andrea Bolognani wrote:
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote:
> +++ b/README.md
> @@ -1,4 +1,4 @@
> -# libvirt-go-xml [](...
[](https://godoc.org/libvirt.org/libvirt-go-xml)
> +# libvirt-go-xml [](https://godoc.org/libvirt.org/libvirt-go-xml)
s/berrange/libvirt/g ;)
Heh, that's what comes from copying the code snippet from the
gitlab admin page
](...](http://Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go-xml)){kind=link}
](https://gitlab.com/berrange/libvirt-go-xml/-/commits/master)){kind=link}
Also, wouldn't
https://gitlab.com/libvirt/libvirt-go-xml/pipelines
be a better location to send people who click on the pipeline status
image?
This is just copied from the recommended badge snippet that gitlab
displays in the "Settings -> CI -> General Pipelines" page. Not sure
why they think sending to the commits page is better, but yeah, it
seems more useful to go the pipelines page.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|