Re: [libvirt] PATCH: Handle changed monitor syntax for PCI hotplug/unplug
On Thu, Jul 16, 2009 at 10:47:44AM +0200, Daniel Veillard wrote:
On Tue, Jul 07, 2009 at 05:45:58PM +0100, Daniel P. Berrange wrote:
> Annoyingly when PCI hotplug support was merged from KVM into QEMU the
> monitor syntax changed :-( This patch tries to deal with this by
> detecting the error message, and then re-trying with the alternative
> syntax.
>
> It also ensures the monitor error mesages is include with any libvirt
> error raised, so that we can more easily detect problems in the future
Okay, patch tries the new syntax first, looks fine, ACK !
Actaully it tries the old syntax first. I should probably reverse it
to use the new syntax first, since that'll be more common
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|