Re: [libvirt] [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults
[adding libvir-list]
On 04/04/2014 05:23 AM, Markus Armbruster wrote:
Paolo Bonzini <pbonzini(a)redhat.com> writes:
> Il 04/04/2014 12:58, Markus Armbruster ha scritto:
>>>>>>
>>>>>> Have you considered extending QEMUMachineInitArgs instead of
adding this
>>>>>> function?
>>>>
>>>> Did not think of this option earlier. You mean doing something like
>>>> this?
>> Yes. Looks nicer, doesn't it?
>
> I still think it's a libvirt bug. Mixing -nodefaults and -usb and
> -device is looking for trouble I think. "-usb" is a do-what-I-mean
> kind of option and it makes sense for it to add a keyboard and mouse,
> even with -nodefaults.
I agree that management tools should not use -usb, except when they want
to manage ancient versions of QEMU for some reason.
We've tried to make libvirt avoid -usb when it knows it is targetting a
new enough qemu. But I'm not the one most familiar with that code. At
this point, I'm just trying to facilitate discussions, and make sure the
right people are looking at this - what versions of qemu vs. libvirt
have you tested, and what does libvirt still need to patch to avoid
-usb, and/or qemu patch so that libvirt can correctly probe that -usb is
not needed?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)