On 06/13/2011 05:01 PM, Daniel P. Berrange wrote:
On Tue, Jun 07, 2011 at 05:11:16PM +0800, Lai Jiangshan wrote:
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> --- tools/virsh.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 4 ++ 2 files changed, 106 insertions(+), 0 deletions(-)
In addition to Daniel's comments:
+ + for_each_variable_arg(cmd, opt) {
This will need rebasing on top of my revised patch 2/10 where I proposed changing the signature of vshCommandOptArgv.
+ if (count == MAX_SEND_KEY) {
and to pick up the new define name
+ vshError(ctl, _("too many keycode"));
s/keycode/keycodes/
+++ b/tools/virsh.pod @@ -296,6 +296,10 @@ scheduling by the hypervisor.
Inject NMI to the guest
+=item B<send-key> I<domain-id> I<--codeset> B<codeset> I<--holdtime> B<holdtime> B<keycode>...
long line, and mark which items are optional: item B<send-key> I<domain-id> optional I<--codeset> B<codeset> optional I<--holdtime> B<holdtime> B<keycode>... [Hmm, we really ought to rewrite virsh.pod to use "[arg]" instead of "optional arg" everywhere, but that's a separate task] I'll wait for a v3 before pushing this patch. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org