Mark McLoughlin wrote:
On Tue, 2007-04-03 at 11:40 +0100, Richard W.M. Jones wrote:
Use AC_SUBST instead of AC_DEFINE because we want autoconf to substitute the value into the Makefile, not into config.h. Then add @QEMUD_PID_FILE@ to CFLAGS.
Sounds sane ...
Bear in mind, though, that ${prefix}/var is the default for $localstatedir ... but all Fedora packages would be built with --localstatedir=/var, just like --sysconfdir=/etc
I don't think you see the problem if you pass a value for --localstatedir
+ -DQEMUD_PID_FILE="\"@QEMUD_PID_FILE@\""
Use $(QEMU_PID_FILE)
OK, that works as well. Are we good to commit this patch and the preceeding one (adding help to libvirt qemu daemon)? Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Charlie Peters (USA) and David Owens (Ireland)