Re: [libvirt] [PATCH v2 10/11] logd: add support for admin protocol in virtlogd

On 01/23/2018 02:23 PM, Daniel P. Berrange wrote: > Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd > daemon and define a virtlogd:///{system,session} URI scheme for > connecting to it. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > src/Makefile.am | 1 + > src/libvirt-admin.c | 20 +++-- > src/logging/log_daemon.c | 149 +++++++++++++++++++++++++++-------- > src/logging/log_daemon_config.c | 3 + > src/logging/log_daemon_config.h | 1 + > src/logging/test_virtlogd.aug.in | 4 + > src/logging/virtlogd-admin.socket.in | 10 +++ > src/logging/virtlogd.aug | 1 + > src/logging/virtlogd.service.in | 1 + > 9 files changed, 149 insertions(+), 41 deletions(-) > create mode 100644 src/logging/virtlogd-admin.socket.in > > diff --git a/src/logging/test_virtlogd.aug.in b/src/logging/test_virtlogd.aug.in > index 3e6888fd48..ee3fae5cde 100644 > --- a/src/logging/test_virtlogd.aug.in > +++ b/src/logging/test_virtlogd.aug.in > @@ -2,6 +2,8 @@ module Test_virtlogd = > let conf = "log_level = 3 > log_filters=\"3:remote 4:event\" > log_outputs=\"3:syslog:virtlogd\" > +max_clients = 10 > +admin_max_clients = 10 > max_size = 131072 > max_backups = 3 > " > @@ -10,5 +12,7 @@ max_backups = 3 > { "log_level" = "3" } > { "log_filters" = "3:remote 4:event" } > { "log_outputs" = "3:syslog:virtlogd" } > + { "max_clients" = "10" } > + { "admin_max_clients" = "10" } > { "max_size" = "131072" } > { "max_backups" = "3" } Improper alignment.