4 May
2018
4 May
'18
4:09 p.m.
On Fri, May 04, 2018 at 10:38:29AM +0200, Katerina Koukiou wrote:
Converting ENUMS to str can be user friendly though it can be problematic in matters of backward compatibility.
In particular when some ENUM in libvirt API will introduce a new constant, libvirt-dbus will fail with:
size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative
So using ints is preferable to avoid the previous issue.
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com> --- data/org.libvirt.Network.xml | 6 ++-- src/network.c | 66 +++----------------------------------------- tests/test_network.py | 2 +- 3 files changed, 8 insertions(+), 66 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>