15 Feb
2008
15 Feb
'08
2:12 p.m.
"Daniel P. Berrange" <berrange@redhat.com> wrote:
On Fri, Feb 15, 2008 at 07:52:37PM +0100, Jim Meyering wrote:
"Daniel P. Berrange" <berrange@redhat.com> wrote: ... Shouldn't size be 1 larger? i.e.,
unsigned long long size = dev->freeExtents[i].end - dev->freeExtents[i].start + 1;
I don't think so - the +1 adjustment is already done in the libvirt_parthelper program, but I'll double-check
Yes, you're right: (from that same patch): + /* We do +1 on geom.end, because we want end of the last sector + * in bytes, not the last sector number