Re: [libvirt] [PATCH 1/6] util: storage: Add helper to determine whether storage is local

On 07/03/2014 12:04 PM, Peter Krempa wrote:

There's a lot of places where we skip doing actions based on the locality of given storage type. The usual pattern is to skip it if:

virStorageSourceGetActualType(src) == VIR_STORAGE_TYPE_NETWORK

Add a simple helper to simplify the pattern to virStorageSourceIsLocalStorage(src)

Are you planning to use it anywhere out of those "lot of places"? :)

--- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 7 +++++++ src/util/virstoragefile.h | 1 + 3 files changed, 9 insertions(+)

ACK Jan