On 02/13/2014 02:09 AM, Michal Privoznik wrote:
Maybe even both additions would be appropriate (a knob for automatic libvirt syncing as well as a new API for explicit syncing outside the events where libvirt would normally do it automatically).
I don't think we should add the <on_resume/> element. After all, it would be the same as:
virDomainResumeFlags(dom, VIR_SYNC_TIME)
which as Dan correctly argues, makes sensible error reporting impossible. If the domain is resumed, libvirt should execute the <on_resume/> action, which may fail.
Or maybe we document that the virDomainResume() api tracks just the resume state, then we add a new libvirt event that says the result of any attempt at a sync operation. Then when you resume, and <on_resume> says to attempt an auto-sync, then you can also listen for the libvirt event that tells you the status of the sync (whether it succeeded (and to what timestamp) or failed). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org