Re: [libvirt] [PATCH 2/4] qemu: Refactor managed save functions to use domain lookup helpers

--- src/qemu/qemu_driver.c | 54 +++++++++++--------------------------------------- 1 file changed, 12 insertions(+), 42 deletions(-)

@@ -3323,50 +3316,28 @@ cleanup: static int qemuDomainHasManagedSaveImage(virDomainPtr dom, unsigned int flags) { - virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm = NULL; - int ret = -1; virCheckFlags(0, -1); - qemuDriverLock(driver); - vm = virDomainFindByUUID(&driver->domains, dom->uuid); - if (!vm) { - char uuidstr[VIR_UUID_STRING_BUFLEN]; - virUUIDFormat(dom->uuid, uuidstr); - virReportError(VIR_ERR_NO_DOMAIN, - _("no domain with matching uuid '%s'"), uuidstr); - goto cleanup; - } - - ret = vm->hasManagedSave; + if (!(vm = qemuDomObjFromDomain(dom))) + return -1; -cleanup: - if (vm) - virDomainObjUnlock(vm); - qemuDriverUnlock(driver); - return ret; + return vm->hasManagedSave; }