Re: [libvirt] [PATCH] Honor blacklist for modprobe command
On Wed, Jan 29, 2014 at 06:32:42AM -0500, John Ferlan wrote:
On 01/29/2014 05:40 AM, Daniel P. Berrange wrote:
> On Tue, Jan 28, 2014 at 07:00:16PM -0500, John Ferlan wrote:
>
> This is getting complex enough that I think we ought introduce
> a src/util/virkmod.{c,h} and have some helper APIs in there
> for loading and unload modules. eg virKModLoad, virKModUnload
> etc
>
This change is for a bz indicating we weren't honoring when a device was
on the blacklist (adding a -b to our modprobe)... The additional or more
complext part was to use the -c was to determine whether that failure
was because the device was already added, but put on the blacklist.
Without that check "any" failure (whether the device doesn't exist or
whether it's on the blacklist) gets the "Failed to load PCI stub module
%s" message which may not help understand why the device cannot be used.
The bug report was related towards "vfio-pci".
Not disagreeing that load/unload isn't a desirable feature, but it seems
out of the scope of the bug report.
This code you're changing though is about module loading if I'm not
mistaken. I'm saying that in improving the error reporting for this
module loading, we should split the code out of this function into
a standalone function.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|