On Fri, Oct 16, 2009 at 01:38:23PM +0100, Daniel P. Berrange wrote:
On Wed, Oct 14, 2009 at 05:29:02PM -0500, Jamie Strandboge wrote:
This is a fix for Ubuntu bug #448671[1]. virt-aa-helper's get_definition() now calls the new caps_mockup() function which will parse the XML for os.type, os.type.arch and then sets the wordsize. These attributes are needed only to get a valid virCapsPtr for virDomainDefParseString(). The -H and -b options are now removed from virt-aa-helper (they weren't used yet anyway). The patch also adds several tests and fixes another.
Please also 'chmod 755 tests/virt-aa-helper-test' so it can be run with 'make check'.
Thanks!
Jamie
ACK, this looks good.
Agreed, pushed now, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/