On 07/12/2018 01:46 PM, Simon Kobyda wrote:
Functions virshSecretEventNameCompleter, virshPoolEventNameCompleter, virshNodedevEventNameCompleter allocates only enough space for array of N strings. However these are null terminated strings, so program needs to alloc space for array of N+1 strings. How to replicate error: valgrind virsh, use completer for '-nodedev-event --event' or '-pool-event --event' or '-secret-event --event'. --- tools/virsh-completer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
The commit message could use some cleaning up. Firstly, there's no need to prepend every line with a TAB (btw remember to put 'set expandtab' into your .vimrc). Secondly, the is no 'Signed-off-By' line which prevents the patch from being merged. Thirdly, the lines are too long and should be cut. The patch looks okay though. Michal