Re: [libvirt] [PATCH 1/2] add --crash support to "virsh dump"
On Mon, Nov 30, 2009 at 03:44:13PM +0100, Paolo Bonzini wrote:
On 11/30/2009 03:27 PM, Daniel P. Berrange wrote:
>Shouldn't we be setting 'resume=0' here otherwise....
>
>>> /* Since the monitor is always attached to a pty for libvirt, it
>>> will support synchronous operations so we always get here
>>after
>>> the migration is complete. */
>>> - if (resume&& paused) {
>>> + else if (resume&& paused) {
>>> qemuDomainObjEnterMonitor(vm);
>>> if (qemuMonitorStartCPUs(priv->mon, dom->conn)< 0) {
>>> if (virGetLastError() == NULL)
>
>....this will try to resume CPUs on a guest we just shutdown
That's why I changed "if" to "else if".
Ah, I didn't notice that was part of the same control flow
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|