On Wed, Feb 08, 2012 at 07:37:19 -0500, Cole Robinson wrote:
On 02/08/2012 02:26 AM, Osier Yang wrote:
>> diff --git a/tests/define-dev-segfault b/tests/define-dev-segfault
>> index 3feff46..0a0532b 100755
>> --- a/tests/define-dev-segfault
>> +++ b/tests/define-dev-segfault
>> @@ -36,6 +36,7 @@ cat<<\EOF> D.xml || fail=1
>> <on_crash>destroy</on_crash>
>> <devices>
>> <emulator>/usr/bin/qemu-kvm</emulator>
>> +<controller type='usb' index='0'/>
>> <serial type='pty'>
>> <target port='0'/>
>> </serial>
But the spacing here is weird... is that my mail client or the actual patch?
That <controller> should be indented. Other tests are similarly changed.
I guess that's the famous thunderbird bug (or is that actually a feature
now?). The original patch is correctly indented.
Jirka