On Tue, May 03, 2016 at 08:18:41PM +0530, Nishith Shah wrote:
On Tue, May 3, 2016 at 8:00 PM, Peter Krempa <pkrempa@redhat.com> wrote:
On Tue, May 03, 2016 at 14:09:42 +0000, Nishith Shah wrote:
Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is no need to pass values in raw bytes, which is seldom the case.
A change like this is incomplete without adding documentation to the virsh man page (tools/virsh.pod) and in the help strings that document the individual arguments in the source file.
Sorry about that, this is my first patch and so I am still figuring things out.
Welcome!
I will add the details in virsh.pod. Can you elaborate a bit on the help strings in this context?
The opts_blkdeviotune[] array contains structs with all the options available for the command. The strings contained in .help are then printed by 'virsh blkdeviotune --help'. Jan