Re: [libvirt] [PATCH 1/1] Change locking for udev monitor and callbacks

On 04/06/2011 04:04 AM, Daniel P. Berrange wrote: > On Tue, Apr 05, 2011 at 04:14:17PM -0500, Serge Hallyn wrote: >> We're seeing bugs apparently resulting from thread unsafety of >> libpciaccess, such as >> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/726099 >> To prevent those, as suggested by danpb on irc, move the >> nodeDeviceLock(driverState) higher into the callers. In >> particular: >> libvirt 0.8.8 with this patch on it seems to work fine for me. >> Assuming it looks ok and I haven't done anything obviously dumb, >> I'll ask the bug submitters to try this patch. > > ACK, it looks good to me - serializing all access to the udev > and libpciaccess APIs is a good conservative approach. I've gone ahead and pushed this; if your bug submitters still have further problems, we can address those in separate patches.