Re: [libvirt] [PATCH 1/2] Implementation deficiency in virInitctlSetRunLevel v4

On 12/20/2013 09:24 AM, Reco wrote: This comment doesn't fit in the commit message; it's better to put review comments... ...here, after the '---' separator, so that 'git am' will strip the information that was useful to reviewers, but not to overall history. For the same reason, your patch should be titled: [PATCHv4 1/2] ... and not [PATCH 1/2] ... v4 since v4 means nothing in libvirt.git (where we don't see the earlier three versions), but only on the mailing list. Also, when sending a series, it's better to stick both 1/2 and 2/2 as in-reply-to a 0/2 cover letter. You can do all that with: git send-email -2 --cover-letter --subject-prefix=PATCHv4 At any rate, since Dan has ack'ed it, and it fixes a CVE (where we're still waiting for the number to be assigned, but the flaw is real), I'll go ahead and push this soon. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org