Re: [libvirt] [PATCH 19/24] maint: improve VIR_ERR_INVALID_SECRET usage

On 12/28/2013 11:11 AM, Eric Blake wrote: > While all errors related to invalid secrets appeared to be > consistent, we might as well continue the trend of using a > common macro. For now, we don't need virCheckSecretGoto(). > > * src/datatypes.h (virCheckSecretReturn): New macro. > (VIR_IS_SECRET, VIR_IS_CONNECTED_SECRET): Drop unused macros. > * src/libvirt.c: Use macro throughout. > (virLibSecretError): Drop unused macro. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/datatypes.h | 17 ++++++++++--- > src/libvirt.c | 79 +++++++++++++++------------------------------------------ > 2 files changed, 33 insertions(+), 63 deletions(-) > Similar to previous the GetUUIDString, GetUsageType, and GetUsageID functions now require a valid connection... although GetUUID checked the connection in the old code.

ACK