On 08/14/2012 11:55 AM, Eric Blake wrote:
On 08/14/2012 01:10 AM, Laine Stump wrote:
> Just as each physical device used by a network has a connections
> counter, now each network has a connections counter which is
> incremented once for each guest interface that connects using this
> network.
>
> The count is output in the live network XML, like this:
>
> <network connections='20'>
> ...
> </network>
>
> It is read-only, and for informational purposes only - it isn't used
> internally anywhere by libvirt.
> ---
> src/conf/network_conf.c | 6 +++++-
> src/conf/network_conf.h | 1 +
> src/network/bridge_driver.c | 10 ++++++++++
> 3 files changed, 16 insertions(+), 1 deletion(-)
Still, I can't help but wonder if someone will try to feed the live
dumpxml output back into libvirt to define a new network config, and
trigger an rng failure as a result - you need to touch
docs/schemas/network.rng. I also think this is missing documentation -
it may be an output-only parameter, but is worth mentioning in
docs/formatnetwork.html.in.
Correct on both counts. You've mostly trained me well wrt rng and docs,
but sometimes I forget :-)
I'll resubmit this last patch, but push them all at once.