Re: [libvirt] [PATCH 2/4] virt-host-validate: distinguish exists vs accessible for devices

On 10/07/2015 12:50 PM, Daniel P. Berrange wrote: >Currently we just check that various devices are accessible. >This leads to inaccurate errors reported for /dev/kvm and >/dev/vhost-net if they exist but an unprivileged user lacks >access. Switch existing checks to look for file existance, >and add a separate check for accessibility of /dev/kvm >since some distros don't grant users access by default. One problem with this is that the people with those distros probably won't be running virt-host-validate under the same uid as used by libvirt when running qemu, so the results won't necessarily tell you what you need - if you run it as root it will say that /dev/kvm is accessible, even though it may not be for the case of the "qemu user", and if you run it as some unprivileged user, if may say that /dev/kvm *isn't* accessible, even though it is in the case of the qemu user.