Re: [libvirt] [jenkins-ci PATCH 03/22] guests, jenkins: Add CentOS 8

On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote: s/,jenkins// [...] These changes are not wrong per se, but I would prefer it if the series had a different structure: * set the stage + this is your first two patches * add support for installing a CentOS 8 guest + all the other hunks of this patch plus the next two + './lcitool install libvirt-centos-8' now works + happens entirely inside the guests/ directory * add projects to CentOS 8 one by one + one patch per project + just tweak the mappings as needed and add the corresponding project to host_vars/libvirt-centos-8/main.yml when done + './lcitool update libvirt-centos-8 $project' should succeed with the patch applied + also requires touching guests/ only * start building projects on CentOS 8 + single patch that enables everything + touches guests/playbooks/build/ and jenkins/ only This structure makes more sense to me because adding libvirt-centos-8 to all_machines feels really wrong when you know that, at that point in time, you wouldn't actually be able to build a single project on the resulting guest. So, in conclusion: Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; to all other hunks, but save these last few for later. -- Andrea Bolognani / Red Hat / Virtualization