On 05/04/2011 07:49 AM, Daniel P. Berrange wrote:
* src/qemu/qemu_migration.c, src/qemu/qemu_migration.h: Remove qemuCaps parameters & use cached data * src/qemu/qemu_driver.c: Don't create & pass qemuCaps to migration methods --- +++ b/src/qemu/qemu_migration.h @@ -61,7 +61,6 @@ virDomainPtr qemuMigrationFinish(struct qemud_driver *driver,
int qemuMigrationToFile(struct qemud_driver *driver, virDomainObjPtr vm, - virBitmapPtr qemuCaps, int fd, off_t offset, const char *path, const char *compressor, bool is_reg, bool bypassSecurityDriver)
Ouch - we changed the offset of parameters within the signature, but not the offset of the corresponding ATTRIBUTE_NONNULL that goes with them. Oh, you already saw this. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org