On Thu, Oct 31, 2013 at 3:32 PM, Eric Blake <eblake@redhat.com> wrote:
On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
Hi All,
I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this?
Thanks.
I think the biggest issue is the new PANICKED state. Guests already have simple ways to halt the CPU, and actually do. I think a new state was a mistake. So how about the following? Does it break anything? (Untested).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 226e298..2055afc 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -51,7 +51,6 @@ static void handle_event(int event)
if (event & PVPANIC_PANICKED) { panicked_mon_event("pause"); - vm_stop(RUN_STATE_GUEST_PANICKED);
Don't you still need to halt the guest on a panic event, for management to have a chance to choose what to do about the panic? I'm suspecting this patch does break things.
I would be happy to apply a patch that just reverted the whole dang mess of this device. Regards, Anthony Liguori
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org