Thanks for pointing out. I will move them to patch qemu: add id when build RNG device and rename object id in next version. Luyao ----- Original Message ----- From: "Peter Krempa" <pkrempa@redhat.com> To: "Luyao Huang" <lhuang@redhat.com>, libvir-list@redhat.com Sent: Monday, January 12, 2015 5:35:54 PM Subject: Re: [libvirt] [PATCH v2 12/12] tests: fix tests to suit qemu args changes for RNG devices On 01/10/15 04:29, Luyao Huang wrote:
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-arm-vexpressa9-virtio.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-s390-piix-controllers.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-s390-usb-none.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-ccw.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-default.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-multiple.args | 8 ++++---- tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args | 4 ++-- 10 files changed, 20 insertions(+), 20 deletions(-)
NACK, this has to be part of the patch that makes the testsuite fail. Every single patch shall pass the testsuite before we commit it to the repository. Peter