Re: [libvirt] [PATCH 4/6] qemu: Transfer migration statistics to destination

On 09/01/2014 11:05 AM, Jiri Denemark wrote: > When migrating a transient domain or with VIR_MIGRATE_UNDEFINE_SOURCE > flag, the domain may disappear from source host. And so will migration > statistics associated with the domain. We need to transfer the > statistics at the end of a migration so that they can be queried at the > destination host. > > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > src/qemu/qemu_migration.c | 190 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 187 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index 208a21f..f1b3d50 100644 > --- a/src/qemu/qemu_migration.c > +++ b/src/qemu/qemu_migration.c

> @@ -589,6 +614,81 @@ qemuMigrationCookieNetworkXMLFormat(virBufferPtr buf, > } > > > +static void > +qemuMigrationCookieStatisticsXMLFormat(virBufferPtr buf, > + qemuDomainJobInfoPtr jobInfo) > +{ > + qemuMonitorMigrationStatus *status = &jobInfo->status; > + > + virBufferAddLit(buf, "<statistics>\n"); > + virBufferAdjustIndent(buf, 2); > + > + virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n", > + VIR_DOMAIN_JOB_TIME_ELAPSED, > + jobInfo->timeElapsed); > + virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n", > + VIR_DOMAIN_JOB_TIME_REMAINING, > + jobInfo->timeRemaining); qemuDomainJobInfoToParams will use jobInfo->type == VIR_DOMAIN_JOB_BOUNDED when printing the above - dies this need to as well?

I would suspect this would be zero anyway, right? Since the job is done.

> + if (status->downtime_set) > + virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n", > + VIR_DOMAIN_JOB_DOWNTIME, > + status->downtime); What about the VIR_DOMAIN_JOB_DATA_* values? I know they are calculable, but since they're