Re: Re: [libvirt PATCH 5/5] Add bios path for loongarch
On Tue, Dec 19, 2023 at 07:44:02PM +0800, lixianglai wrote:
> On Thu, Dec 14, 2023 at 02:08:49PM +0800, xianglai li wrote:
> The way firmware is configured these days is through firmware
> descriptor files. See src/qemu/qemu_firmware* and tests/qemufirmware*
> for additional information, but the short version is that you want
> your edk2 package to include something like this:
>
> # /usr/share/qemu/firmware/50-edk2-loongarch64.json
> {
> "interface-types": [
> "uefi"
> ],
> "mapping": {
> "device": "flash",
> "mode" : "split",
> "executable": {
> "filename":
"/usr/share/edk2/loongarch64/QEMU_CODE.fd",
> "format": "raw"
> },
> "nvram-template": {
> "filename":
"/usr/share/edk2/loongarch64/QEMU_VARS.fd",
> "format": "raw"
> }
> },
> "targets": [
> {
> "architecture": "loongarch64",
> "machines": [
> "virt",
> "virt-*"
> ]
> }
> ]
> }
Ok, I will remove the custom bios path and then try to add json in the qemu
and edk2 installation packages.
Note that the JSON descriptor files in tests/qemufirmwaredata/ are
taken directly from the Fedora edk2 package, and in the long run we
want that to be the case for loongarch too, but you don't necessarily
need to wait for the firmware to be packaged in Fedora before
creating libvirt test cases. You can just have a file containing
reasonable-looking values, such as the ones I've shown above, to get
things going, and then we can replace it with the actual one for
Fedora at a later time.
The QEMU package itself doesn't ship any JSON descriptor files.
--
Andrea Bolognani / Red Hat / Virtualization