On 10/08/2013 06:06 PM, Eric Blake wrote:
On 10/08/2013 03:57 PM, Cole Robinson wrote:
On 10/08/2013 05:48 PM, Eric Blake wrote:
On 10/08/2013 03:39 PM, Cole Robinson wrote:
The copyright date syntax check is a source of frustration for me:
- It fails on old maint branches.
In general, 'make syntax-check' is NOT guaranteed to work on maint branches, nor is it worth trying to make it work there. If anything, the best thing to do would be figuring out how to patch 'make syntax-check' to be a complete no-op on maint branches and only operate on a (descendant of) the master branch, precisely because out-of-order backports to maint branches makes it practically impossible to guarantee that we can consistently meet whatever style future development on the master branch decides is now in vogue.
Agreed on that for the most part. It can still be beneficial to run, particularly after a hairy backport though, and it's frustrating to be blocked on something like a copyright date. But you're right that we can never guarantee it will continue to work.
You can always run 'make -k syntax-check' or even 'make sc_name_of_test' to keep going or limit the checking to the subset of tests you care about.
Doh, I always forget about -k :/ Yes that's a reasonable workaround to all my complaints. Thanks, Cole