Re: [Libvir] PATCH: 5/10: public auth callback API

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: ... I guess you did the above because something in src/ or qemud/ now requires the generated libvirt.h? ... This is a good demonstration of why using sizeof (type name) is fragile. Given code like T *var = calloc (n, sizeof (T)); I prefer this: T *var = calloc (n, sizeof (*var)); Then when type T changes, like it just did above, you don't have to be careful to update all sizeof arguments that are somehow related to "var". Not to say you should change your patch. If no one objects on principle, I'll do the global cleanup, eventually. BTW, changing the above code gives this: ret->types.types_val = calloc (ret->types.types_len, sizeof (*(ret->types.types_val))) == NULL) { which is a good argument for using a helper macro. e.g., #define CALLOC(Var,N) do { (Var) = calloc ((N), sizeof (*(Var))); } while (0) Of course, if you can have statement-expression macros (gcc-specific), you can do better, but I don't think we can depend on compiling with gcc.