On 08/11/2011 09:12 PM, Daniel Veillard wrote:
On Thu, Aug 11, 2011 at 08:39:23PM -0600, Eric Blake wrote:
We forgot to add virDomainUndefineFlags for a couple of hypervisors. This wires up trivial versions (since neither hypervisor supports managed save yet, they do not need to support any flags).
* src/vbox/vbox_tmpl.c (vboxDomainCreateXML): Update caller. (vboxDomainUndefine): Move guts... (vboxDomainUndefineFlags): ...to new function. * src/xenapi/xenapi_driver.c (xenapiDomainUndefine) (xenapiDomainUndefineFlags): Likewise. ---
I'm still debating on whether implementations that lack managed save should trivially support 'undefine --managed-save' (there's none to undefine), instead of the current behavior of rejecting it as an unknown flag. But that's an independent question.
What I'll probably do is teach virsh to treat --managed-save as a no-op if a domain does not support managed save rather than forcing the flag down to the client to be rejected; touching just virsh is nicer than touching every single hypervisor to add an ignored flag bit, and I already have to touch virsh undefine to implement new --snapshot flags.
ACK,
Pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org