Re: [libvirt] [PATCH 19/26] network_conf: Resolve Coverity FORWARD_NULL

On 09/05/14 00:26, John Ferlan wrote:

The code compares def->forwarders when deciding to return 0 at a couple of points, then uses "def->nfwds" as a way to index into the def->forwarders array. That reference results in Coverity complaining that def->forwarders being NULL was checked as part of an arithmetic OR operation where failure could be any one 5 conditions, but that is not checked when entering the loop to dereference the array. Changing the comparisons to use nfwds will clear the warnings

Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/network_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

ACK