Re: [libvirt] [PATCH] virsh migrate: Fix positional parameters
On Mon, Jun 20, 2016 at 13:07:31 +0200, Andrea Bolognani wrote:
On Mon, 2016-06-20 at 10:31 +0200, Jiri Denemark wrote:
> Thanks to our smart option parser which automatically assigns positional
> parameters the following (previously working) command fails:
>
> virsh migrate test qemu+ssh://1.2.3.4/system tcp://1.2.3.4/
> error: invalid argument: Unsupported compression method
> 'tcp://1.2.3.4/'
>
> We need to make sure new options are added at the end of the list rather
> than where they logically belong.
>
> Reported by Brian Rak.
>
> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> ---
> tools/virsh-domain.c | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
ACK
Pushed, thanks.
Jirka