Re: [PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime and cache size

On 11/03/21 12:54, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berrange(a)redhat.com) wrote: > > The generic 'migrate_set_parameters' command handle all types of param. > > > > Only the QMP commands were documented in the deprecations page, but the > > rationale for deprecating applies equally to HMP, and the replacements > > exist. Furthermore the HMP commands are just shims to the QMP commands, > > so removing the latter breaks the former unless they get re-implemented. > > > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > > Yes OK; ouch that's going to break my 7 years of instinctive > 'migrate_set_speed 10G' typing, but it's probably the right thing to do. migrate_set_speed should remain if it is not changed to have a sane default.