Re: [libvirt] [PATCH 07/33] Remove usage of brctl command line tool

On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: >From: "Daniel P. Berrange"<berrange(a)redhat.com> > >Convert the virNetDevBridgeSetSTP and virNetDevBridgeSetSTPDelay >to use ioctls instead of spawning brctl. > >Implement the virNetDevBridgeGetSTP and virNetDevBridgeGetSTPDelay >methods which were declared in the header but never existed > >* src/util/bridge.c: Convert to use bridge ioctls instead of brctl >--- > configure.ac | 2 - > libvirt.spec.in | 2 - > src/util/bridge.c | 199 +++++++++++++++++++++++++++++++++++++++++++++++++---- > 3 files changed, 184 insertions(+), 19 deletions(-)

>@@ -817,22 +924,54 @@ cleanup: > int virNetDevBridgeSetSTPDelay(const char *brname, > int delay) > { >- virCommandPtr cmd; >+ int fd = -1; Also applicable for the other patches, the initialization to -1 doesn't seem necessary.