Daniel P. Berrange wrote:
On Wed, Feb 20, 2008 at 10:24:18PM -0800, Dave Leskovec wrote:
A sample XML format that can be used to define a linux container domain: <domain type='linuxcontainer'> <name>TestContainer3</name> <container> <filesystem type='mount'> <source dir='/home/user/lxc_files/etc/'/> <target dir='/etc/'/> </filesystem> <filesystem type='mount'> <source dir='/home/user/lxc_files/var/'/> <target dir='/var/'/> </filesystem> <init>/usr/sbin/container_init</init> </container> <memory>65536</memory> <devices> <console tty='/dev/pts/4'/> </devices> </domain>
Having thought about this all since our previous round of discussions on the matter I'm of the opinion we should /not/ use the <container> block for filesystem setup - it should be part of the <devices> block. This will simplify impl for apps which already have support for dealing with devices and hot add/remove (virDomainAttachDevice/virDomainDetachDevice). The <init> element can stay in <container> or perhap go inside an <os> block since that's where we describe booting for non-container virt.
That makes sense to me. I guess I'd lean towards leaving <init> in the container block since a container isn't really starting a new os image. Perhaps Dan Smith has some comments on this... -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization