Re: [libvirt] [PATCH] virsh: Always print capacity unit

19 Feb 2013

On Tue, Feb 19, 2013 at 14:22:44 +0000, Daniel P. Berrange wrote:
...
On Mon, Feb 18, 2013 at 03:48:28PM +0100, Jiri Denemark wrote:
...
It doesn't make sense to print the unit (B) only with Ki, Mi, ...
prefixes. Even those poor bytes under 1 KiB are still bytes :-)
---
 tools/virsh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index f5a01b3..d64e539 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -148,7 +148,7 @@ double
 vshPrettyCapacity(unsigned long long val, const char **unit)
 {
     if (val < 1024) {
-        *unit = "";
+        *unit = "B";
         return (double)val;
     } else if (val < (1024.0l * 1024.0l)) {
         *unit = "KiB";
ACK
Thanks, pushed.

Jirka

    