On 07/18/2011 03:17 PM, Jiri Denemark wrote:
> That said, why can't virsh be smarter, and automatically
request the
> right underlying flags without making the user also type --p2p? Any
> problems with this patch?
No problem at all, I think it's a very good idea.
> From db318d41c2a70189c21303c824aa4a862815874a Mon Sep 17 00:00:00 2001
> From: Eric Blake<eblake(a)redhat.com>
> Date: Mon, 18 Jul 2011 13:10:29 -0600
> Subject: [PATCH] virsh: make migrate --tunnelled imply --p2p
>
> We can make the virsh migrate UI friendlier by supplying the
> missing bit automatically instead of erroring out when requesting
> --tunnelled without --p2p.
>
> * tools/virsh.c (doMigrate): Make --p2p optional when using
> --tunnelled.
> * tools/virsh.pod (migrate): Tweak wording accordingly.
> ---
> tools/virsh.c | 2 +-
> tools/virsh.pod | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
So, here is my ACK
Pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org