Re: [libvirt] [PATCH] qemu: format serial, geometry and error policy on frontend disk device

On Mon, Jun 25, 2018 at 10:50:32 +0100, Daniel Berrange wrote: > Currently we format the serial, geometry and error policy on the -drive > backend argument. > > QEMU added the ability to set serial and geometry on the frontend in > the 1.2 release, and ability to set error policy in the 2.7 release. > usb-storage is an oddity, however, as it lacks error policy support > right now. > > Setting any of these on -drive has been deprecated and support for this > will be removed very soon. > > Note that some disk buses (sd) still don't support -device. Although > QEMU allowed these properties to be set on -drive for if=sd, they > have been ignored so we don't loose anything by removing this. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt;

> @@ -2125,6 +2141,11 @@ qemuBuildDriveDevStr(const virDomainDef *def, > if (qemuBuildDriveDevCacheStr(disk, &opt, qemuCaps) < 0) > goto error; > > + qemuBuildDiskFrontendAttributes(disk, &opt); > + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISK_ERROR) && > + disk->bus != VIR_DOMAIN_DISK_BUS_USB) Why is USB special here? Switching to -blockdev will require doing this also for the USB disk, so I'd rather have a single case here.