On 03/15/2013 08:35 AM, Daniel P. Berrange wrote:
On Mon, Feb 25, 2013 at 06:44:24PM +0100, Paolo Bonzini wrote:
This reuses the XML format that was introduced for Gluster.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- docs/formatdomain.html.in | 8 ++-- src/qemu/qemu_command.c | 49 +++++++++++++++------- tests/qemuargv2xmltest.c | 1 + .../qemuxml2argv-disk-drive-network-nbd-unix.args | 5 +++ .../qemuxml2argv-disk-drive-network-nbd-unix.xml | 33 +++++++++++++++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmltest.c | 1 + 7 files changed, 80 insertions(+), 19 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-unix.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-unix.xml
ACK
Pushed, after fixing this 'make syntax-check' failure: src/qemu/qemu_command.c:2524: virReportError(VIR_ERR_INTERNAL_ERROR, src/qemu/qemu_command.c-2525- _("socket attribute required for unix transport")); maint.mk: found diagnostic without % and rewrapping tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-unix.args to fit 80 columns. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org