Re: [PATCH v3 0/7] Allow Guest CPU Model with Deprecated Features Disabled
On Mon, Dec 16, 2024 at 18:03:51 -0500, Collin Walling wrote:
# Changelog
v3
- added reviewed-by's on appropriate patches
- split patch #4 into three:
- domain API (libvirt-domain: introduce
VIR_CONNECT_GET_DOMAIN_CAPABILITIES_DISABLE_DEPRECATED_FEATURES)
- qemu (qemu_capabilities: filter deprecated features if requested)
- virsh (virsh: add --disable-deprecated-features flag to domcapabilities)
- Note: no functional change, patches were split based on changes to certain
files
- @Jiri, let me know if this is what you had in mind, I found it difficult to
find a good reference
- fixed deprecated_props array missing +1 in qemuJSONMonitor* functions
- condensed cputypes schema for deprecated_features
- added validation in qemu_process to check if QEMU cap is present
- added qemuxmlconf tests
- updated version tags to 11.0.0
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>
I fixed the small issue in 2/7 with the following diff and pushed the
series, thanks.
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 8590a1a0a5..df7e0d8997 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -3351,11 +3351,7 @@ qemuMonitorCPUModelInfoCopy(const qemuMonitorCPUModelInfo *orig)
}
}
- if (orig->deprecated_props) {
- copy->deprecated_props = g_new0(char *,
- g_strv_length(orig->deprecated_props));
- copy->deprecated_props = g_strdupv(orig->deprecated_props);
- }
+ copy->deprecated_props = g_strdupv(orig->deprecated_props);
return copy;
}