Re: [libvirt] [PATCH] Various monitor cleanups related to migration.
Daniel P. Berrange wrote:
On Wed, Sep 30, 2009 at 01:27:20PM +0200, Chris Lalancette wrote:
> The upcoming tunnelled migration needs to be able to set
> a migration in progress in the background, as well as
> be able to cancel a migration when a problem has happened.
> This patch allows for both of these to properly work.
NACK, these are internal methods intentionally not exported since their
usage is dependant on the text based monitor syntax.
You should add another qemuMonitorMigrateToUNIX() API for doing UNIX
socket based migration which simply takes the socket path name,
and use the qemuMonitorMigrateToCommand() API for the back-compat
exec/nc based impl.
Can easily add another boolean flag to these for putting migration
in the background too
OK, I wasn't quite sure if this one would fly. I've pushed the preliminary
cleanup patches; I'll rework this one and the Tunnelled migration one with your
fixes/suggestions.
--
Chris Lalancette