Re: [libvirt] [PATCH RFC 18/51] qemu: blockjob: Add functions for block job state control

17 Jan 2019

On Mon, Jan 07, 2019 at 14:35:08 +0100, Ján Tomko wrote:
...
On Wed, Dec 12, 2018 at 06:08:34PM +0100, Peter Krempa wrote:
...

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
[...]
...
...
index 637307806b..9e5171744e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4716,7 +4716,7 @@ processBlockJobEvent(virQEMUDriverPtr driver,
                     int status)
{
    virDomainDiskDefPtr disk;
-    qemuBlockJobDataPtr job;
+    qemuBlockJobDataPtr job = NULL;
if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
        return;
@@ -4731,7 +4731,11 @@ processBlockJobEvent(virQEMUDriverPtr driver,
        goto endjob;
    }
-    job = QEMU_DOMAIN_DISK_PRIVATE(disk)->blockjob;
+    if (!(job = qemuBlockJobDiskGetJob(disk))) {
Can qemuBlockJobDiskGetJob really return NULL here?
Not at this point in the series but it will become the case later.

    