20 May
2010
20 May
'10
6:16 p.m.
On 05/20/2010 01:23 PM, Cole Robinson wrote:
Volume detection in the scsi backend was duplicating code already present in storage_backend.c. Let's drop the duplicate code.
Also, change the shared function name to be less generic, and remove some error squashing in the other call site.
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/storage/storage_backend.c | 4 ++-- src/storage/storage_backend.h | 4 ++-- src/storage/storage_backend_mpath.c | 2 +- src/storage/storage_backend_scsi.c | 32 ++------------------------------ 4 files changed, 7 insertions(+), 35 deletions(-)
Nice cleanup. ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org