Re: [libvirt PATCH v2 4/6] qemu_snapshot: correctly load the saved memory state file
On Fri, Sep 01, 2023 at 10:32:15 +0200, Pavel Hrdina wrote:
Original code assumed that the memory state file is only migration
stream but it has additional metadata stored by libvirt. To correctly
load the memory state file we need to reuse code that is used when
restoring domain from saved image.
This duplicates some necessary parts of qemuSaveImageStartVM() because
the external snapshot memory state is done by qemuSaveImageCreate().
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_snapshot.c | 115 +++++++++++++++++++++++++++++++++------
1 file changed, 97 insertions(+), 18 deletions(-)
Hmmm, in the end you were right. This version is more verbose and in
fact doesn't end up having two code paths for external and internal but
both call qemuProcessStart which still does everything together.
I'll re-visit v1. Since my main concern is not aleviated by this one and
I think v1 can be made tolerable by improving some function
documentation.
Regardless of the above:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
as I went through this pathc already.