Re: [libvirt] [PATCH tck 5/6] Convert nwfilter and domain balloon tests to virtbuilder images

On Friday, March 28, 2014 12:26:31 PM Daniel P. Berrange wrote: > Change tests which need a full OS image over to use the new > virtbuilder images instead of provisioning from a kickstart > file. This should make them much more reliable to run. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > scripts/domain/110-memory-balloon.t | 10 ++-- > scripts/nwfilter/090-install-image.t | 55 --------------------- > scripts/nwfilter/100-ping-still-working.t | 54 ++++++++++----------- > scripts/nwfilter/210-no-mac-spoofing.t | 81 > +++++++++++++++++-------------- scripts/nwfilter/220-no-ip-spoofing.t | > 78 +++++++++++++++++------------ scripts/nwfilter/230-no-mac-broadcast.t > | 53 +++++++++++--------- scripts/nwfilter/240-no-arp-spoofing.t | 60 > +++++++++++++---------- scripts/nwfilter/300-vsitype.t | 40 > ++++++++------- > scripts/nwfilter/nwfilter_concurrent.sh | 4 +- > 9 files changed, 212 insertions(+), 223 deletions(-) > delete mode 100644 scripts/nwfilter/090-install-image.t As mentioned in my last email, can you add the following change to 100-ping- still-working.t as well? > -# fixme to include mac adress > -ok($ebtable1 =~ "vnet0", "check ebtables entry"); > +my $ebtable = `/sbin/ebtables -L;/sbin/ebtables -t nat -L`; > +diag $ebtable; > +# ebtables shortens :00: to :0: so we need to do that too > +$_ = $mac; > +s/00/0/g; > +ok($ebtable =~ $_, "check ebtables entry");