Re: [libvirt] [PATCH] vmx: Remove check that numvcpus has to be an even number.
On Wednesday, 30 May 2018 11:33:45 CEST Richard W.M. Jones wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1584091
It is possible to create a VMware guest with an odd number of vCPUs,
but such guests cannot be accessed by libvirt because of this
unnecessary check.
I retained the sanity-check that numvcpus must be >= 1.
Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com>
---
NACK until there is a reply to
https://www.redhat.com/archives/libvir-list/2018-May/msg02159.html
Also, this patch is incomplete, since:
- there giant "documentation" comment at the beginning was not updated
- virVMXFormatConfig has the very same check
That is why I did not send this patch yet: the check was added on
purpose (documented, and implemented), so there must be a reason, even
if trivial. I can take care of this, but after knowing a bit more.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)